Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golems #295

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from
Draft

Golems #295

wants to merge 45 commits into from

Conversation

Ermucat
Copy link

@Ermucat Ermucat commented Jan 9, 2025

About the PR

Added a new species, the golem a servent for whoever made it, made from an anomaly core. Currently the golem is missing its groin, and missing a proper base sprite.

Why / Balance

Adds more depth to science and a new feature for people to play around with

Technical details

Added Golem Sprites
Added Clown Naming sound
Added Related harmony Files
Added Golem Construction Graphs
Added Golem Naming Ftl

Media

2025-01-08.11-27-40.mp4

Requirements

Breaking changes

Changelog

🆑

  • add: Added a new species, the golem

Ermucat and others added 27 commits December 7, 2024 08:58
Signed-off-by: FluffMe <1780586+FluffMe@users.noreply.github.com>
Signed-off-by: FluffMe <1780586+FluffMe@users.noreply.github.com>
Signed-off-by: Ermucat <NCramey09@gmail.com>
…implants.yml

Signed-off-by: Ermucat <NCramey09@gmail.com>
Signed-off-by: Ermucat <NCramey09@gmail.com>
Signed-off-by: Ermucat <NCramey09@gmail.com>
Copy link
Collaborator

@DieselMohawk DieselMohawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to note that a SprintSpeedModifiers are multiplicative, not additive.

As such, for them to be 90% the speed of other species, set the modifier to "0.9" rather than "-0.1"

@DieselMohawk
Copy link
Collaborator

DieselMohawk commented Jan 9, 2025

I recommend finding examples of components you wish to use and see how they work.

Also, please set this PR to draft while you work on it, you can do internal tests on your device to check and see if it works.

Use the following in your console:

dotnet test --no-build --configuration DebugOpt Content.IntegrationTests/Content.IntegrationTests.csproj -- NUnit.ConsoleOut=0 NUnit.MapWarningTo=Failed

and

dotnet run --project Content.YAMLLinter/Content.YAMLLinter.csproj --no-build

@DieselMohawk
Copy link
Collaborator

I recommend finding examples of components you wish to use and see how they work.

Also, please set this PR to draft while you work on it, you can do internal tests on your device to check and see if it works.

Use the following in your console:

dotnet test --no-build --configuration DebugOpt Content.IntegrationTests/Content.IntegrationTests.csproj -- NUnit.ConsoleOut=0 NUnit.MapWarningTo=Failed

and

dotnet run --project Content.YAMLLinter/Content.YAMLLinter.csproj --no-build

The top command are the integration and content tests. The bottom test is the YAML Linter test.

DieselMohawk
DieselMohawk previously approved these changes Jan 9, 2025
@DieselMohawk DieselMohawk dismissed their stale review January 9, 2025 21:09

Wrong button, you did fix what I saw though.

@FluffMe
Copy link
Collaborator

FluffMe commented Jan 9, 2025

Drafted

@FluffMe FluffMe marked this pull request as draft January 9, 2025 21:19
@FluffMe FluffMe removed the S: Needs Review Review is requested label Jan 9, 2025
… missing their rear end, but we have no more fatal errors, this 12 hour, sleep-deprived escapade of an idea is finally over
@DieselMohawk
Copy link
Collaborator

Hex Code is likely screwed due to the initial sprite being colored already

@Ermucat
Copy link
Author

Ermucat commented Jan 9, 2025

Yeah all the orignal parts are colored, which screws with the sprites a lot. But luckily most of them work just fine, just any that are yellow, red, or any shade of white or black that get messed with

@Ermucat Ermucat requested a review from DieselMohawk January 10, 2025 04:16
@Ermucat Ermucat marked this pull request as ready for review January 10, 2025 04:16
@github-actions github-actions bot added the S: Needs Review Review is requested label Jan 10, 2025
@Ermucat Ermucat marked this pull request as draft January 10, 2025 05:09
@DieselMohawk
Copy link
Collaborator

Thanks boss

@FluffMe FluffMe removed the S: Needs Review Review is requested label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants